plotly / dash-cytoscape

Interactive network visualization in Python and Dash, powered by Cytoscape.js
https://dash.plot.ly/cytoscape
MIT License
597 stars 120 forks source link

Ctx menu merge #107

Closed mj3cheun closed 7 months ago

mj3cheun commented 4 years ago

About

Adds ctxmenu plugin to dash-cytoscape. Modifications made to original PR to place ctxmenu specific login in separate file as was done for responsive.

Pre-Merge checklist

Reference Issues

Closes #58

Update of #69

Other comments

xhluca commented 4 years ago

Thanks for opening this PR! Seems like the tests are failing:

======================================================================
ERROR: test_usage_responsive_graph (tests.test_usage.Tests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/circleci/project/tests/test_usage.py", line 76, in test_usage_responsive_graph
    self.create_usage_test('demos.usage-ctxmenu')
  File "/home/circleci/project/tests/test_usage.py", line 11, in create_usage_test
    app = importlib.import_module(filename).app
  File "/usr/local/lib/python3.6/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 994, in _gcd_import
  File "<frozen importlib._bootstrap>", line 971, in _find_and_load
  File "<frozen importlib._bootstrap>", line 955, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 665, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 678, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/circleci/project/demos/usage-ctxmenu.py", line 177, in <module>
    'top': 0
  File "/home/circleci/project/venv/lib/python3.6/site-packages/dash/development/base_component.py", line 366, in wrapper
    return func(*args, **kwargs)
  File "/home/circleci/project/dash_cytoscape/Cytoscape.py", line 211, in __init__
    super(Cytoscape, self).__init__(**args)
  File "/home/circleci/project/venv/lib/python3.6/site-packages/dash/development/base_component.py", line 112, in __init__
    ", ".join(sorted(self._prop_names))
TypeError: The `dash_cytoscape.Cytoscape` component (version 0.2.0) with the ID "cytoscape" received an unexpected keyword argument: `ctxmenu`
Allowed arguments: autoRefreshLayout, autolock, autoungrabify, autounselectify, boxSelectionEnabled, className, elements, generateImage, id, imageData, layout, maxZoom, minZoom, mouseoverEdgeData, mouseoverNodeData, pan, panningEnabled, responsive, selectedEdgeData, selectedNodeData, style, stylesheet, tapEdge, tapEdgeData, tapNode, tapNodeData, userPanningEnabled, userZoomingEnabled, zoom, zoomingEnabled

======================================================================
ERROR: test_usage_responsive_graph (tests.test_usage.Tests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/circleci/project/tests/IntegrationTests.py", line 47, in tearDown
    self.server_process.terminate()
AttributeError: 'Tests' object has no attribute 'server_process'

----------------------------------------------------------------------
Ran 13 tests in 148.903s

FAILED (errors=2)
sys:1: ResourceWarning: unclosed <socket.socket fd=3, family=AddressFamily.AF_INET, type=SocketKind.SOCK_STREAM, proto=6, laddr=('127.0.0.1', 49248), raddr=('127.0.0.1', 55153)>

Exited with code exit status 1
CircleCI received exit code 1

Would you mind trying to run this specific test locally and see what went wrong?

Farkites commented 7 months ago

Closing this PR in favour of #196