Rewrite tests with dash testing

plotly / dash-cytoscape

Interactive network visualization in Python and Dash, powered by Cytoscape.js

https://dash.plot.ly/cytoscape

MIT License

595 stars 120 forks source link

Rewrite tests with dash testing #153

Closed kinimesi closed 2 years ago

kinimesi commented 3 years ago

About

Fixes #118, rewrite the tests with `dash[testing]` ## Description of changes

Pre-Merge checklist

[x] The project was correctly built with npm run build:all.
[ ] If there was any conflict, it was solved correctly.
[ ] All changes were documented in CHANGELOG.md.
[x] All tests on CircleCI have passed.
[ ] All Percy visual changes have been approved.
[ ] Two people have :dancer:'d the pull request. You can be one of these people if you are a Dash Cytoscape core contributor.

Reference Issues

Closes #[issue number]

Other comments

xhluca commented 3 years ago

Hey on a first look the code seems fine, however there are a lot of missing images:

Can you investigate why those are not being generated? should be about 100 images if you run the tests locally

kinimesi commented 3 years ago

I'll look into it, thanks.

kinimesi commented 2 years ago

It should be fixed now. However, it needs manual approval. Since dash_duo.percy_snapshot combines the snapshot name with the actual python versions, percy cannot match them by name to visually compare (that's why right now it says 103 viaul changes need review)

kinimesi commented 2 years ago

Thanks @alexcjohnson I mainly rewrote the existing code by using dash.testing and kept the existing structure. I'll update them based on your feedback.