Experimental: microbundled react-cytoscapejs - Githubissues

plotly / dash-cytoscape

Interactive network visualization in Python and Dash, powered by Cytoscape.js

https://dash.plot.ly/cytoscape

MIT License

587 stars 120 forks source link

Experimental: microbundled react-cytoscapejs #180

Closed akx closed 1 year ago

akx commented 2 years ago

About

As requested by @alexcjohnson in https://github.com/plotly/react-cytoscapejs/pull/99#issuecomment-1182411086 , this pulls in the https://github.com/plotly/react-cytoscapejs/pull/99 version of react-cytoscapejs and adds cytoscape as a direct dependency (as it is a peer dependency of react-cytoscapejs going forward).

I ran npm run build:all and tried some of the demos/ – everything seems to work just fine.

👉 This PR should not be merged as-is, though, since the package.json specifier for react-cytoscapejs is not a published version. (That's why this is left as a draft.)

Description of changes

Please see above.

Pre-Merge checklist

[x] The project was correctly built with npm run build:all.
[x] If there was any conflict, it was solved correctly.
[ ] All changes were documented in CHANGELOG.md.
[ ] All tests on CircleCI have passed.
[ ] All Percy visual changes have been approved.
[ ] Two people have :dancer:'d the pull request. You can be one of these people if you are a Dash Cytoscape core contributor.

Reference Issues

https://github.com/plotly/react-cytoscapejs/pull/99

akx commented 1 year ago

Merged in plotly/react-cytoscapejs#99.