search

plotly / dash-daq

Control components for Dash
MIT License
141 stars 40 forks source link

Bugfix for min gauge values > 0 #170

Open rolandFleddermann opened 2 years ago

rolandFleddermann commented 2 years ago

The color locations were off before when the minimum value of a gauge scale was set to a value > 0.

for example in this case

Gauge( id="demoGauge", label="Gauge", logarithmic=False, min=50, max=150, scale={"start": 50, "interval": 10, "labelInterval": 10}, value=100, showCurrentValue=True, color={"gradient": False, "default": "lightblue", "ranges": {"red": [50, 100], "yellow": [100, 110],"green": [110, 150]}} ),

before the fix it would render like this:

before: image

and after: image

Unfortunately the diff does not render all that well, all that happened is that I removed the if (minimum < 0) { block and changed the indent level inside...

alexcjohnson commented 1 year ago

Thanks @rolandFleddermann - and apologies that we haven't gotten a chance to review this yet. This repo has had a whole bunch of work added to it a while back that we haven't had a chance yet to QA and release, but I'm hoping we can get to that in the next couple of months!