search

plotly / dash-daq

Control components for Dash
MIT License
141 stars 40 forks source link

Added left and right options for labelPosition in toggles. #31

Closed Akronix closed 1 year ago

Akronix commented 5 years ago

This is a straightforward intent to fix #29.

I have noted that there are more components which use labelPosition, I could also change their react props if you find this PR useful.

Let me know if there's anything else I'm missing.

Akronix commented 5 years ago

ping @shammamah

shammamah-zz commented 5 years ago

@Akronix Would you mind resetting the irrelevant files (i.e., anything that doesn't have to do with your specific changes) to the versions on master? There are lots of diffs in the PR that amount to pretty-printing or documentation. Would make it easier to review :)

Akronix commented 5 years ago

Let's see now :)

shammamah-zz commented 5 years ago

Not sure if it worked -- if you go into "Files changed", you'll see that the documentation files still have diffs. I think it's because there are some hooks in place for this repository that auto-gen the documentation at each commit. I'll just build the package and test your code in the meantime!

Shourai commented 5 years ago

Hey @shammamah, this looks like a great addition to the toggles. Any update on merging this pull request? Thanks!

shammamah-zz commented 5 years ago

@Akronix @Shourai Yes, this is a great addition! Apologies for not having gotten to it earlier.

@Akronix would you be able to merge in the latest master into your fork? We've made quite a few changes, including ones that will fix this auto-doc-generation issue.

Akronix commented 5 years ago

@Akronix @Shourai Yes, this is a great addition! Apologies for not having gotten to it earlier.

@Akronix would you be able to merge in the latest master into your fork? We've made quite a few changes, including ones that will fix this auto-doc-generation issue.

I'm pretty much AFK until 15th of August. is it fine if I do it after that? Please ping me if I forget about it after then or even on the same 15th :smiley:

shammamah-zz commented 5 years ago

Sure no worries!

kjsr7 commented 3 years ago

@Akronix @shammamah Any update on this one? Or is there any alternative that is currently available

RemDelaporteMathurin commented 2 years ago

@Akronix @shammamah-zz can we have an update on this? I couldn't find a way to have a label left of any toggle... it seems this PR is dead. I don't mind trying to reimplement it if @Akronix doesn't wish to merge it. In that case maybe it should be closed?

Akronix commented 1 year ago

Sorry, I'm closing this because of lack of time and because currently I'm working in a very different area. Though, anyone can use whatever they want from my code.