search

plotly / dash-daq

Control components for Dash
MIT License
141 stars 40 forks source link

LEDDisplay handle negative numbers #41

Closed ghost closed 5 years ago

ghost commented 5 years ago

In this PR, the minus sign is handled as a digit, and must be in first position. See issue #12.

ghost commented 5 years ago

Sorry, I'm not responsible of the adjunction of .react to all the md docs, this has been done automatically when I commit changes. Is this normal?

ghost commented 5 years ago

@shammamah any thoughts on this?

shammamah-zz commented 5 years ago

Hey!

Sorry, I'm not responsible of the adjunction of .react to all the md docs, this has been done automatically when I commit changes. Is this normal?

Yeah, that's run automatically when you build the package: https://github.com/plotly/dash-daq/blob/master/bin/generateDocs

Sorry, I'm not responsible of the adjunction of .react to all the md docs, this has been done automatically when I commit changes. Is this normal?

That's another side effect of building the package (nothing you need to worry about).

Have you been able to install the package locally and run demo.py without any issues?

ghost commented 5 years ago

Everything works: python demo.py is running(without change) and npm run demo gives this output.

image

ghost commented 5 years ago

I'd like to delete my github account. Are you interested in this PR, or should I close it.

shammamah-zz commented 5 years ago

@benjaminabel I can take care of it from here on out!

bearsh commented 5 years ago

any news on this? In one application we use the led display to display user selectable data which also include e.g. data from an accelerometer which can be negative...

shammamah-zz commented 5 years ago

@bearsh This PR looks like it's an orphan, so I made the same changes in #52. I'll let you know when that's merged in!