Modifications to support dash-daq R package development

plotly / dash-daq

Control components for Dash

MIT License

141 stars 40 forks source link

Closed rpkyle closed 5 years ago

rpkyle commented 5 years ago

This PR proposes to make three changes in support of building in R package support for dash-daq:

fix missing locationSlider entry and docstring in Slider.propTypes within Slider.react.js
update package.json with additional metadata for R package DESCRIPTION file
include JavaScript bundles in dash_daq (required by 'transpiler', will copy into R package inst subdirectory)

The initial R package has also been committed to this branch.

shammamah-zz commented 5 years ago

@rpkyle Would you be able to add these changes into the CHANGELOG under the next version (0.1.5)?

rpkyle commented 5 years ago

@rpkyle Would you be able to add these changes into the CHANGELOG under the next version (0.1.5)?

fixed in feb7b4ee47d4568e837307ef1692dea55b89c812

rpkyle commented 5 years ago

🎉 @shammamah mind giving me a dancing-themed emoji? 🙂

shammamah-zz commented 5 years ago

💃