Closed shammamah-zz closed 5 years ago
inst/deps
should not be removed except if you plan on making dev
the default branch for DAQ, and the repo updated in a similar way as what was done in core. For now, suggest adding them back and make the master/dev artifact/no-artifact a follow up.
I'll be regenerating the bundle/build artifacts once this PR gets approved (just in case the dependencies need to be changed).
Closes #61. Closes #34.
About
dash-components-archetype
in build processdash-generate-components
builder
dependency and all related files/scriptsstyled-components
version to4.x
(previous production versions were breaking, due to a warning in development mode turning into a breaking error in production mode: see https://github.com/styled-components/styled-components/issues/1709)styled-components
3.x
, and failed upon update to4.0.0
(my hypothesis is that this updated added another wrapping "layer" around components):render()
in some cases (see: https://airbnb.io/enzyme/docs/api/ShallowWrapper/render.html), sincesetProps
calls were not actually updating the props{component}.state(...)
to{component}.prop(...)
, since the state wasn't updating in tests (and it doesn't make a lot of sense to usesetProps
and then... not check the propscomponentWillReceiveProps
->UNSAFE_componentWillReceiveProps
- see https://reactjs.org/docs/react-component.html#unsafe_componentwillreceiveprops); these will probably need to be changed later tooDigit
elements in thePrecisionInput
component to also check forExponentialDigit
; even thoughExponentialDigit
"extends"Digit
, the new version ofstyled-components
gives them different classes so a.find(Digit)
wasn't returningExponentialDigit
elements