fix ci - Githubissues

plotly / dash-deck

Bringing deck.gl and pydeck into Dash

https://dash-gallery.plotly.host/dash-deck-explorer/

MIT License

90 stars 19 forks source link

fix ci #21

Closed graingert-coef closed 7 months ago

graingert-coef commented 8 months ago

About

CI was failing, so I fixed the failing tests. After this I found that the tests were flaky in starting up the browsers for testing so I upgraded to the new cimg images with updated browsers.

Description of changes

Pre-Merge checklist

[ ] The project was correctly built with npm run build.
[ ] If there was any conflict, it was solved correctly.
[ ] All changes were documented in CHANGELOG.md.
[x] All tests on CircleCI have passed.
[ ] All Percy visual changes have been approved.
[ ] Two people have :dancer:'d the pull request. You can be one of these people if you are a Dash Deck core contributor.

Reference Issues

Closes #[issue number]

Other comments

graingert-coef commented 8 months ago

@jingningzhang1 can I get a review please?

alexcjohnson commented 8 months ago

@graingert-coef this looks great, thanks! Is this a precursor to #22 or are they independent?

FYI the stance we've taken throughout the Dash ecosystem is to drop Py3.7 support at this point as well, so 3.8 will be the minimum supported version in the next release of any package.

graingert-coef commented 8 months ago

@alexcjohnson this is a precursor to #22

graingert-coef commented 8 months ago

FYI the stance we've taken throughout the Dash ecosystem is to drop Py3.7 support at this point as well, so 3.8 will be the minimum supported version in the next release of any package.

I've dropped Python 3.6 and 3.7 in #22

graingert-coef commented 7 months ago

@alexcjohnson I reverted that commit and it seems to install fine now - I suspect something to do with caching now rather than the venv already existing on cimg images

graingert-coef commented 7 months ago

failing CI was here: https://app.circleci.com/pipelines/github/plotly/dash-deck/51/workflows/d5bd5a29-ab59-490c-a665-972497fee596/jobs/149?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-checks-link&utm_content=summary I googled the error message and found this: https://discuss.circleci.com/t/python-venv-setup-no-longer-working-as-expected-build-failing/45531/2 and this https://discuss.circleci.com/t/upgrading-to-the-convenience-image-breaks-everything/42746

so seems just changing the cache key should fix it

alexcjohnson commented 7 months ago

OK great, really appreciate you digging into the venv issue, due to its impact on other projects!