Update of deck-gl versions to 8.9.34 with fixed CI and drop EOL Python 3.6 and 3.7 - Githubissues

plotly / dash-deck

Bringing deck.gl and pydeck into Dash

https://dash-gallery.plotly.host/dash-deck-explorer/

MIT License

90 stars 19 forks source link

Update of deck-gl versions to 8.9.34 with fixed CI and drop EOL Python 3.6 and 3.7 #22

Closed graingert-coef closed 7 months ago

graingert-coef commented 8 months ago

About

this is https://github.com/plotly/dash-deck/pull/20 with my changes that fix CI and an update to deck.gl 8.9.34

Description of changes

Pre-Merge checklist

[ ] The project was correctly built with npm run build.
[ ] If there was any conflict, it was solved correctly.
[ ] All changes were documented in CHANGELOG.md.
[ ] All tests on CircleCI have passed.
[ ] All Percy visual changes have been approved.
[ ] Two people have :dancer:'d the pull request. You can be one of these people if you are a Dash Deck core contributor.

Reference Issues

Closes #[issue number]

Other comments

alexcjohnson commented 7 months ago

@graingert-coef FYI, I was about to make a release (tentatively 0.1.0 but I'm tempted to call it 1.0.0 if we get it fully working) but noticed some errors running demos/usage-events.py:

Screenshot 2024-02-13 at 22 24 28

I didn't try with just this PR so it's possible #26 caused this, though that one should be fairly uncontroversial. My hunch is the structure of certain events got more complex with the new deck.gl version, but it's not clear to me which events are causing this. I also haven't tried any of the other demo apps yet. v0.0.1 does not have this issue.