search

plotly / dash-pivottable

react-pivottable in Dash
MIT License
192 stars 52 forks source link

Remove dash_pivottable.dev.js from package #28

Open rpkyle opened 4 years ago

rpkyle commented 4 years ago

The dash_pivottable.dev.js file appears currently unused by either the Python or R packages, and is approximately 20 MB in size.

If possible, I'd suggest only building this additional JS via webpack when needed. For example, in dash-renderer's package.json we have

    "build:js": "webpack --build release",
    "build:dev": "webpack --build local",

which we use to control whether source maps are generated as well.

This recently caused friction with submitting the package to CRAN:

Thanks, we see:

Size of tarball: 5900811 bytes

Not more than 5 MB for a CRAN package, please.

Please fix and resubmit.

If we're able to make this change, the uncompressed R package size will plummet to 3 MB from over 20 MB, and the compressed archive will be approximately 1 MB.

@xhlulu @Marc-Andre-Rivet

Marc-Andre-Rivet commented 4 years ago

The dev build here just seems to be there to include source-maps. Seems ok to 🔪 from MANIFEST and webpack.config.js (except if we want to keep it for local development for some reason)

xhluca commented 4 years ago

Good idea for Manifest.in. I don't know how removing it from webpack.config.js would affect the build process, but if you both think it's a good idea let's do it.