search

plotly / dash-player

Dash Component wrapping React-Player
MIT License
77 stars 12 forks source link

dash-player/metadata.json not commited #4

Closed Multihuntr closed 2 years ago

Multihuntr commented 6 years ago

Hey, found your dash component wrapper for this player and was interested in trying it out, but when trying to import dash-player, it says No such file or directory: '/code/dash_player/metadata.json'.

I admit to not knowing exactly how making a Dash component works, but I found an issue on the base dash-core-components which pointed me to the .gitignore file, and it seems that the dash-player/metadata.json file is not being tracked, but is required to run this player.

Multihuntr commented 6 years ago

Oh! Found something else describing this problem and a solution. Turns out it's a generated file, anyway.

So, the solution is to add npm prepublish after npm install to generate it. I'll put in a pull request to modify the README.md with this additional step.

alexshoe commented 2 years ago

This this comment