search

plotly / dash-player

Dash Component wrapping React-Player
MIT License
77 stars 12 forks source link

Fix typo #57

Closed LiamConnors closed 1 year ago

alexshoe commented 1 year ago

Thanks for making this fix @LiamConnors. Would you mind making sure your PR passes all the tests? I can approve as soon as that's done

alexshoe commented 1 year ago

@LiamConnors, I forgot to mention that you'll need to run npm run build in order to rebuild the package as well

LiamConnors commented 1 year ago

Thanks @alexshoe, npm run build brought in some other changes too: https://github.com/plotly/dash-player/pull/57/files#diff-69bf43dfa1742c00789bd3a792ada573b73143461a0fd110363edfa587520572R98-R102 Would that just be because it wasn't run last time something was merged?