plotly / dash-player

Dash Component wrapping React-Player
MIT License
77 stars 12 forks source link

Make component async #73

Closed LiamConnors closed 1 year ago

LiamConnors commented 1 year ago

Wasn't sure @alexcjohnson , should this map.js file go in the MANIFEST https://github.com/plotly/dash-player/pull/73/files#diff-41d5a52589e0480be9c099d2bba7a8135b8b0d71bcbb8df3582a8df1c2295003R4

alexcjohnson commented 1 year ago

Oh let's add a changelog entry.

Don't need to do it in this PR unless you want to, but the one other thing we should do before publishing a new release is update deps:

> ncu
 @babel/core                                 ^7.19.1  →   ^7.21.0
 @babel/plugin-proposal-object-rest-spread   ^7.18.9  →   ^7.20.7
 @babel/preset-env                           ^7.19.1  →   ^7.20.2
 @types/node                                ^18.7.18  →  ^18.14.6
 babel-loader                                 ^8.2.5  →    ^9.1.2
 css-loader                                   ^6.7.1  →    ^6.7.3
 eslint                                      ^8.23.1  →   ^8.35.0
 eslint-config-prettier                       ^8.5.0  →    ^8.7.0
 eslint-plugin-import                        ^2.26.0  →   ^2.27.5
 eslint-plugin-react                         ^7.31.8  →   ^7.32.2
 react-player                                 2.11.0  →    2.12.0
 styled-jsx                                   ^5.0.7  →    ^5.1.2
 webpack                                     ^5.74.0  →   ^5.76.0
 webpack-cli                                 ^4.10.0  →    ^5.0.1

I don't think we actually use @types/node or styled-jsx in this project, do we? Maybe take them out, delete node_modules and reinstall, and see if it still builds?

And I would suggest we call the next release 1.1.0 since async is a fairly substantial change even if most folks won't see it as explicitly a new feature