search

plotly / dash-player

Dash Component wrapping React-Player
MIT License
77 stars 12 forks source link

console error #78

Open eckdqja opened 1 year ago

eckdqja commented 1 year ago

a b

No problem with playback, but console error exposed

mycode in layout: c

alexcjohnson commented 1 year ago

Thanks @eckdqja - looks like this line:

https://github.com/plotly/dash-player/blob/79b595710d1531bb2afa5702e41373eeee70a933/src/lib/fragments/DashPlayer.react.js#L146

should say className={className} instead. It's not exactly documented as a prop either way, but the underlying component does show one example with className: https://github.com/CookPete/react-player#responsive-player

eckdqja commented 8 months ago

I request a correction through an update. (Release) I hope the issue will be resolved.