search

plotly / dash-renderer

OBSOLETE has been merged into dash
https://github.com/plotly/dash
MIT License
97 stars 32 forks source link

Dash Dev Tools #100

Closed rmarren1 closed 5 years ago

rmarren1 commented 5 years ago

Built on https://github.com/plotly/dash-renderer/pull/64.

rmarren1 commented 5 years ago

I believe the tests are failing because of https://github.com/plotly/dash-core-components/pull/384

rmarren1 commented 5 years ago

@valentijnnieman confirmed previous comment. This is the branch of dev tools you can work with with plotly origin.

rmarren1 commented 5 years ago

Looks like this problem still remains...

After investigating a bit more the input clear bug, it boils down to the way selenium clear the input. It doesn't send the onChange event for the cleared value so somehow the initial value get backs in. This is not something that would happen if the user cleared the input manually with backspaces or selecting the whole text and deleting. Thus, it is safe to patch the failing tests to fix that selenium bug.

T4rk1n commented 5 years ago

Yes it's still there, what is fixed is the callback counts, we need to modify the failing test.

byronz commented 5 years ago

@alexcjohnson @Marc-Andre-Rivet would like to get some feedback on the last two fixes & improvement of unit tests:

  1. test initial state
  2. test test_callbacks_generating_children

it demonstrates the direction to make test case more concise and robust, but the current enhancements are still not ideal as the scope of each test is still big and lack of granularity.

nicolaskruchten commented 5 years ago

Let's remember to add some tests for the dev bundle :)

nicolaskruchten commented 5 years ago

possibly we should add some tests to the prod bundle that ensure that it's not "too big" ?