search

plotly / dash-renderer

OBSOLETE has been merged into dash
https://github.com/plotly/dash
MIT License
97 stars 32 forks source link

Issue 104 - Add source map to NPM and PyPi packages #105

Closed Marc-Andre-Rivet closed 5 years ago

Marc-Andre-Rivet commented 5 years ago

Fixes #104 Relates to plotly/dash#478 Relates to https://github.com/plotly/dash-table/issues/284 Relates to https://github.com/plotly/dash-core-components/issues/404

valentijnnieman commented 5 years ago

Got a 500 error the first time I did a review, seems it posted it twice now. Whoops!

Marc-Andre-Rivet commented 5 years ago

If anyone wonders, the dev js file is smaller but removing the "eval source map" causes it to take 1 line per code line instead of squishing everything (with evals), explaining the 30k lines diff

T4rk1n commented 5 years ago

Getting a Uncaught SyntaxError: Unexpected token : log with the dev bundle.

Marc-Andre-Rivet commented 5 years ago

That's because we're not using the dynamic flag yet. When loaded "correctly" through the devtools this will not happen anymore.

T4rk1n commented 5 years ago

The external code map works for debugging, looked like it was even more stable for dev bundle. The min bundle also debugged but it was jumping over things.

:dancer:

Marc-Andre-Rivet commented 5 years ago

The external code map works for debugging, looked like it was even more stable for dev bundle. The min bundle also debugged but it was jumping over things.

Thanks for checking this out. I thought we might be able to get rid of the dev build after the change but if you see improved behavior when debugging with it, let's keep it.