Make lint fail build when there are linting errors

plotly / dash-renderer

OBSOLETE has been merged into dash

https://github.com/plotly/dash

MIT License

97 stars 32 forks source link

Closed Marc-Andre-Rivet closed 5 years ago

Marc-Andre-Rivet commented 5 years ago

The current npm lint command has the --quiet, which means that when running this command in CI and will not fail the build.

Suggest splitting this in two commands

lint checks and fails on linting errors
lint.fix checks and fixes linting errors if it can (retaining the current dev-side work case)

alexcjohnson commented 5 years ago

@valentijnnieman fixed this in #75