Fix e2e tests & bump dash version to master

plotly / dash-renderer

OBSOLETE has been merged into dash

https://github.com/plotly/dash

MIT License

97 stars 32 forks source link

Fix e2e tests & bump dash version to master #120

Closed Marc-Andre-Rivet closed 5 years ago

Marc-Andre-Rivet commented 5 years ago

Fixes https://github.com/plotly/dash-core/issues/19

Marc-Andre-Rivet commented 5 years ago

So essentially the rendering looks fine in Selenium but broken in Percy.. I have no idea why :( :-1:

Marc-Andre-Rivet commented 5 years ago

@alexcjohnson At this point my thinking is as follow: Revert back to fixing the tests, accepting the delta in Percy (manual testing shows that it displays correctly) and winging the Percy investigation in another issue -- we know Percy does this, this is not a new issue, it just happens to be exposed by the dcc version bump.

Marc-Andre-Rivet commented 5 years ago

Follow up issue for Percy: https://github.com/plotly/dash-core/issues/43