search

plotly / dash-renderer

OBSOLETE has been merged into dash
https://github.com/plotly/dash
MIT License
97 stars 32 forks source link

Fix hot reload #157

Closed chriddyp closed 5 years ago

chriddyp commented 5 years ago

Fixes https://github.com/plotly/dash/issues/634

chriddyp commented 5 years ago

hotreload

chriddyp commented 5 years ago

It looks like our existing hot reload tests don't test python changes yet (only css changes).

I think that getting proper python integration tests here might be a bit more work, so I'd like to get this fix merged in first and then loop back later on integration tests.

chriddyp commented 5 years ago

Best to review this one commit-by-commit

byronz commented 5 years ago

my current understanding of this part leading to a black box reviewing, I verified the fix with the reloading issue I see with dash-docs, from the network traffic, it seems works properly now with both hard and soft reload. :dancer:

better have another approval from @alexcjohnson or @Marc-Andre-Rivet