Fix setProps when IDs aren't provided

plotly / dash-renderer

OBSOLETE has been merged into dash

https://github.com/plotly/dash

MIT License

97 stars 32 forks source link

Fix setProps when IDs aren't provided #166

Closed chriddyp closed 5 years ago

chriddyp commented 5 years ago

Fixes #165

alexcjohnson commented 5 years ago

@chriddyp this is awesome (my :dancer: stands BTW, despite the extra discussion). But @byronz merged some of the if(id) hacks in https://github.com/plotly/dash-core-components/pull/523, do we need to remove them now? Seems like they could actually be harmful once this PR is merged.

chriddyp commented 5 years ago

Yeah - I think I'll follow up with a PR that cleans up some of the DCC logic. I think that the id => setState is actually still "safe" but it could be cleaned up - many of the components can become functional & stateless