search

plotly / dash-slicer

A volume slicer for Dash
https://dash.plotly.com/slicer
MIT License
24 stars 8 forks source link

configure deployment on playground with circleCI #19

Closed emmanuelle closed 3 years ago

emmanuelle commented 3 years ago

Still WIP since the creation of new apps from the CI does not work yet, but apart from this the deployment works.

emmanuelle commented 3 years ago

@almarklein I think this is now ready for review (I'll squash commits before merging :-).

almarklein commented 3 years ago

Out of curiosity, I assume the playground is used by more dash-related projects. If two projects that use it happen to have a pr open with a branch name that is the same, we'll have a name clash, right? (not a big deal, but good of be aware of)

almarklein commented 3 years ago

This LGTM, by the way!

emmanuelle commented 3 years ago

Out of curiosity, I assume the playground is used by more dash-related projects. If two projects that use it happen to have a pr open with a branch name that is the same, we'll have a name clash, right? (not a big deal, but good of be aware of)

You're right and I considered that this is not a big deal since the playground is just a sandbox (used for things like continuous deployment and work in progress). But it's easy to prefix the branch name with 'slicer' so that the risk of fortuitous clashes is very much reduced, I'll do that.

almarklein commented 3 years ago

I'll avoid branch names called "dev" from now on ;)