plotly / dash-slicer

A volume slicer for Dash
https://dash.plotly.com/slicer
MIT License
24 stars 8 forks source link

Add support for setting indicator color #29

Closed almarklein closed 3 years ago

almarklein commented 3 years ago

afbeelding

nicolaskruchten commented 3 years ago

Hmm the border is a bit intense... I wonder if maybe just having the corners highlighted would be enough? Like an indicator line along both sides of every corner for 20 pixels or something?

almarklein commented 3 years ago

Hmm the border is a bit intense...

Yeah, I played a bit with slimmer lines, but certain colors would be barely visible then. I'll try the corners-thing.

emmanuelle commented 3 years ago

Maybe a matter of color and taste, but I'm fine with lines as they are now. And it helps a lot with the navigation, love this feature!!

emmanuelle commented 3 years ago

What do you think @surchs? Are lines too thick or ok? We need more opinions :-).

almarklein commented 3 years ago

Added another possible approach to the top post. edit: And also Nicolas' suggestion.

surchs commented 3 years ago

Nice, this looks very cool and makes it easier to use! I like the lines as well with the current thickness. Maybe to denote the individual axis graphs, we could just use a thick line on the bottom, rather than a complete border. And maybe this "indicator" line should be optional and default to hidden when no slicer colour is defined (or they all default to turquoise).

nicolaskruchten commented 3 years ago

I think this is looking pretty great! The corner indicators could be a little smaller perhaps, and I personally preferred the "outer tick" style of indicators for the other two, that way they don't occlude the figure, but that's maybe just a personal style thing.

It would be awesome to get these indicators somehow reflected in the 3d view as well if possible in the example with the 3d plot :)

almarklein commented 3 years ago

@nicolaskruchten afbeelding

nicolaskruchten commented 3 years ago

zomg that's cool

almarklein commented 3 years ago

Ready for review.

The corner-indicators are now actually square, and have the same size in each view targeting the same volume.

Quite a few changes, I also renamed some variables, and refactored a bit.

almarklein commented 3 years ago

Hold on - After discussion with @nicolaskruchten I'm going to try changing how we define the "indicator ranges".