plotly / dash-slicer

A volume slicer for Dash
https://dash.plotly.com/slicer
MIT License
24 stars 8 forks source link

Add support for extra traces #40

Closed almarklein closed 3 years ago

almarklein commented 3 years ago

I considered using pattern matching, which would make it possible for the application to define multiple stores for additional traces. However, by simply proving a store via a property, we make the simpler cases easier, and the more complex cases can still define multiple stores and then add a callback to aggregate these into the slicer.extra_traces.

Possible alternative names for extra_traces could be e.g. user_traces, `more_traces.

emmanuelle commented 3 years ago

Thanks! The checklist above mentions that you added an example showing a contour but I could not find it, did you maybe forget to add it?

emmanuelle commented 3 years ago

Regarding the name, I like both extra_traces and user_traces (not so much more_traces). Maybe a slight preference for extra_traces ?

almarklein commented 3 years ago

[...] did you maybe forget to add it?

Yes I did :)

[...] Maybe a slight preference for extra_traces ?

Let's just stick with extra_traces then.

emmanuelle commented 3 years ago

Just a color-related nitpicking comment, but it looks good to go!