Speed Up selecting/deselecting all rows. And sorting columns that contained a lot of same values

plotly / dash-table-experiments

NO LONGER SUPPORTED - use https://github.com/plotly/dash-table instead

MIT License

174 stars 57 forks source link

Speed Up selecting/deselecting all rows. And sorting columns that contained a lot of same values #20

Closed EvgeniiAl closed 6 years ago

chriddyp commented 6 years ago

Very nice @EvgeniiAl ! 👏 Thanks for following the Ramda style too 🌟

EvgeniiAl commented 6 years ago

@chriddyp Thanks to your great work! I am afraid my fix still have some issue, when user deselect one of many selected rows, updating selected rows will take a huge amount of time :(

chriddyp commented 6 years ago

Woops, I think I merged too early then. I've reverted the change in this PR: https://github.com/plotly/dash-table-experiments/pull/21, feel free to reopen once you fix that last issue that you are seeing :)

chriddyp commented 6 years ago

@EvgeniiAl - Just wanted to follow up here. Did this PR slow things down or did it just not fix all of the issues? In other words, are we safe to merge this PR without any performance degradation or did it introduce new issues?

EvgeniiAl commented 6 years ago

@chriddyp I hope this can be safely merged.