Div doesn't resize to small amount of rows (see image)

plotly / dash-table-experiments

NO LONGER SUPPORTED - use https://github.com/plotly/dash-table instead

MIT License

174 stars 57 forks source link

Div doesn't resize to small amount of rows (see image) #25

Closed ucg8j closed 6 years ago

ucg8j commented 6 years ago

There is a lot of whitespace left if the rows displayed are less than ~10 rows. See the screenshot below.

I'm posting this as an issue to seek any feedback prior to a PR.

chriddyp commented 6 years ago

Yeah, it would be great if this was fixed. I know that react-data-grid has a lot of constraints when it comes to sizing as it doesn't render all cells at once, only those in the viewport.

I recommend looking through the react-data-grid repo for similar issues. For example, https://github.com/adazzle/react-data-grid/issues/207 and https://github.com/adazzle/react-data-grid/issues/736

Let me know if you need any help getting started!

ucg8j commented 6 years ago

See PR27

chriddyp commented 6 years ago

Fixed in #27