search

plotly / dash-table-experiments

NO LONGER SUPPORTED - use https://github.com/plotly/dash-table instead
MIT License
174 stars 57 forks source link

Added functionality to calculate min_height when the datatable is under 10 items #27

Closed ucg8j closed 6 years ago

ucg8j commented 6 years ago

Per issue 25 this PR fixes the sizing.

chriddyp commented 6 years ago

This looks good to me @ucg8j ! Just one small comment. Also, could you bump the minor version number to 0.5.1 (https://github.com/plotly/dash-table-experiments/blob/master/dash_table_experiments/version.py) and add an entry in the CHANGELOG.md file: https://github.com/plotly/dash-table-experiments/blob/master/CHANGELOG.md?

ucg8j commented 6 years ago

Hi @chriddyp - all done. Let me know if there's anything else. Big thanks to @RenzoDS too!

chriddyp commented 6 years ago

Great, thanks @ucg8j ! Just one last comment here: https://github.com/plotly/dash-table-experiments/pull/27#discussion_r156166599

ucg8j commented 6 years ago

Done :)

chriddyp commented 6 years ago

Thanks @ucg8j !