plotly / dash-table-experiments

NO LONGER SUPPORTED - use https://github.com/plotly/dash-table instead
MIT License
174 stars 57 forks source link

increasing display length #38

Closed xiaoluffy closed 6 years ago

xiaoluffy commented 6 years ago

Hi,

dash-table-experiments is great! But the default display rows of datatable is 9. I found a way to work out by setting iDisplayLength of DataTable, but is there a simple way to work out by dash-table-experiments and Python code only?

And min_height does not work well as I expected. app.layout = html.Div([ html.H4('test1'), dt.DataTable( rows=df.to_dict('records'), columns=df.columns, row_selectable=True, filterable=True, min_height=2000, sortable=True, selected_row_indices=[], id='datatable-gapminder' ), html.Div(id='selected-indexes') ], className="container")

Thanks!

chriddyp commented 6 years ago

I believe that this was fixed in #37 which I released on v0.5.4. I'll close this for now, but feel free to reopen if this bug isn't fixed yet

gennadyi commented 6 years ago

Not fixed yet! Cant make table with more than 9 visible rows. Infact min_height really has nothing to do with number of rows. Should be separate parameter.

only case for <10 works,

10 should be a parameter called num_visible_rows !! min_height is not enough

============================== getMinHeight() {

gennadyi commented 6 years ago

I can't reopen. But @xiaoluffy should reopen this issue.

xiaoluffy commented 6 years ago

hi, I tried the same code today and it works by min_height. thanks!