couture-ql
commented
5 years ago It may be useful to skip setting the last cell width to allow react-table-grid to do the calculation for us. See attached before and after:
I did not want to introduce a feature that does something people may not expect -- the last column to always be the size they specified. Instead, introduce a new knob allowing callers to explicitly request to let the last column size to be calculated by react-table-grid. Technically, users can avoid this 'issue' by defining n-1 column widths, and the last item will be calculated by react-table-grid. However, if users want or need to define the same number of widths as there are columns, adding a knob might be helpful to specify the desired behaviour.
bpostlethwaite
Currently, DataTable provides a way for users to define column widths, which is useful for flexibility. However, when tables and pre-set columns do not match up perfectly, the last column can fall short of the calculated width of the table viewport. Adding a new flag to allow callers to skip setting the fixed width of the last column, such that it will be calculated by react-table-grid instead, allowing it to be a sane width.
Fixes an issue where setting fixed widths may cause last item to fall short of calculated container.
Signed-off-by: Jamie Couture jamie@quandl.com