Closed wbrgss closed 4 years ago
@Marc-Andre-Rivet What is this requirements.txt
file? The only place I see it mentioned is in the "local server review apps" section of CONTRIBUTING.md
. For running npm run build
I'd think you want to be in an environment that has dash[dev]
installed, and that'll bring along PyYAML
with it (and then after that reinstall the table repo -e
).
Re: Werkzeug - I guess that should have been updated with Flask in https://github.com/plotly/dash-table/pull/536, but I don't know why this requirements.txt
file is locking down things we don't depend on directly, that seems like a recipe for all sorts of problems, unless this file is autogenerated from some other clean install process
@alexcjohnson I think this file is used for the Heroku deployment from GH:
Not sure if dev-requirements
and python-requirements
have any use at this point though.
@wbrgss pyyaml
should be installed automatically with pip install dash[dev]
. We might have to update the contributing guidelines instead to specify that that package should be installed.
Removing the pyyaml
entry. As @shammamah pointed out this is included with dash[dev]
.
When running
npm run build
in this repo, within a virtual environment:0.15.6
I gotMaybe we could also use a different version of Flask. In the end it might be a Flask bug (see here)
pyyaml
from pip:I'm using PopOS (a flavour of Ubuntu 19.04). @Marc-Andre-Rivet can you check if bumping the Werkzeug version breaks anything in your env and/or whether
pyyaml
is already in your env?