Fix short Firefox cell height for dropdown cells

plotly / dash-table

OBSOLETE: now part of https://github.com/plotly/dash

https://dash.plotly.com

MIT License

420 stars 72 forks source link

Fix short Firefox cell height for dropdown cells #665

Closed wbrgss closed 4 years ago

wbrgss commented 4 years ago

Fixes #663 (issue described in detail there; TLDR Firefox table cell height is off)

~Solution from https://stackoverflow.com/questions/3215553/make-a-div-fill-an-entire-table-cell#comment40719119_7600749~

I don't think this has any side effects with Chrome; i.e. it only helps parity between Chrome and FF rendering.

wbrgss commented 4 years ago

Before tab

After fixed-table-height

wbrgss commented 4 years ago

Looking at Percy, this seems to fix what I wanted on Firefox (and there are 11 more Firefox changes in the diff), but it also seems to shorten rows without dropdowns (?), including in Chrome.

wbrgss commented 4 years ago

OK, I changed the style rules and got it down to 11 Firefox diffs and 0 Chrome diffs, which is what I want. Please review when you have a chance @Marc-Andre-Rivet

Marc-Andre-Rivet commented 4 years ago

@wbrgss Updated the branch and added a changelog file