plotly / dash-table

OBSOLETE: now part of https://github.com/plotly/dash
https://dash.plotly.com
MIT License
420 stars 72 forks source link

Prepend stats:: to setNames call #689

Closed rpkyle closed 4 years ago

rpkyle commented 4 years ago

The dashTable package includes a df_to_list helper function, which relies on the setNames function from the stats package.

The latter is generally attached when R is started, so the fact that we did not import the setNames function in the NAMESPACE file previously was never an issue before, but we really should, as the CRAN test in R CMD check attests. I'm trying to submit the latest core packages to CRAN soon, and right now dashTable fails the check for this reason.

This is a minor change, and I can make it to dev as well. Editing df_to_list so that the call is to stats::setNames will have essentially the same effect as editing the NAMESPACE, and requires no edits to the package generator.