plotly / dash-table

OBSOLETE: now part of https://github.com/plotly/dash
https://dash.plotly.com
MIT License
420 stars 72 forks source link

Regression: dash-loading is no longer set, CSS spinners cannot be used #761

Open noisycomputation opened 4 years ago

noisycomputation commented 4 years ago

In release 4.6.1 (with dash 1.10), the div with class name 'dash-spreadsheet-inner' would add the class name "dash-loading" while the table was loading. Release 4.6.2 (with dash 1.11) no longer sets this class property.

This property is useful because dcc.Loading does not work well with dash-tables / DataTables. The dcc.Loading spinner is triggered when any callback affecting the table is triggered, which is often not the desired behavior (e.g. spinner is desired when table data is updated via a database call, but not when a cell is clicked).

I can't make sense of the organization of typescript projects, so I haven't been able to determine what change caused this regression.