plotly / dash-table

OBSOLETE: now part of https://github.com/plotly/dash
https://dash.plotly.com
MIT License
420 stars 72 forks source link

added className and text properties to DataTable to style export button #799

Closed jwbargsten closed 3 years ago

jwbargsten commented 4 years ago

This PR adds two props for the DataTable, export_className and export_text. This allows to modify the class and the text of the export button. Very useful if you want to style the button with e.g. bootstrap classes or translate the button text.

Pre-Merge checklist

Post-Merge checklist

bratao commented 3 years ago

Any chance of approving this MR? @alexcjohnson For App in other languages this MR would be essential

alexcjohnson commented 3 years ago

@jwbargsten @bratao sorry, somehow this one slipped off our radar. It looks good, I just had a couple of minor comments.

jwbargsten commented 3 years ago

something went wrong during rebase on dev. I'll fix it and then wrap it up.

jwbargsten commented 3 years ago

I rebased/fixed this PR now 2x, and given the lack of progress, I somehow lost (a little bit) the confidence that this will be resolved. I suggest to close it therefore.