Issue 840 - Fix proptypes & syntax highlighting, and improve tests

plotly / dash-table

OBSOLETE: now part of https://github.com/plotly/dash

https://dash.plotly.com

MIT License

419 stars 74 forks source link

Issue 840 - Fix proptypes & syntax highlighting, and improve tests #841

Closed Marc-Andre-Rivet closed 3 years ago

Marc-Andre-Rivet commented 3 years ago

Closes #840

adds log checks for all table tests
standardizes tests/integration tests with tests/selenium tests using the newer fixture / pattern
removes python-3.6 CI job (to be removed on approval) and percy/dash-table-python-v0 (those two visual tests have been flaky since forever and never uncovered a bug anyway)

As part of improving the tests, found an additional regression breaking highlight.js after https://github.com/plotly/dash-table/pull/814 -- this does not affect dcc as it uses 9.x and the usage there is correct.

alexcjohnson commented 3 years ago

Removing Py3.6 tests - interesting... I guess there's an argument that components only need to test with the latest Python, as they have no independent Python code, and in the main dash repo we create test components and test them against multiple Python versions, verifying that the generated code will all work across versions.

That said table has some Python helper functions for formatting, which it would be nice to test will work across versions. On the other hand how much longer are we even going to support Py2, which would be the main reason for such a test?

So in the end I'd say yeah, this is fine.

Marc-Andre-Rivet commented 3 years ago

For https://github.com/plotly/dash-table/pull/841#issuecomment-712549984 - the formatter tests are currently run with the unit tests, on py37 only. The py36 tests are a misnomer as all that job really did was (1) load two apps with table/graph and take a screenshot of them, (2) run some export tests. Tests in (1) don't really test anything, tests in (2) were moved with the other e2e tests.