search

plotly / dash-table

OBSOLETE: now part of https://github.com/plotly/dash
https://dash.plotly.com
MIT License
420 stars 74 forks source link

Attempt to fix incorrect tooltip placement #906

Open adament opened 3 years ago

adament commented 3 years ago

This is an attempt to fix #872, the interpretation of the row value of currentTooltip was inconsistent across the codebase. In this patch I try to fix the row value to mean the row in the current displayed data which means that getSelectedTooltip needs to convert to the row number of the full dataset. It works for filtering and pagination in the demo application. However I have not tested with a proper virtualized dataset.

I have little to no experience with javascript, typescript or developing dash components so there is a great risk that I have overlooked something trivial.

Thank you very much for an amazing tool in dash table.

adament commented 3 years ago

I am not really sure what is wrong with the lint or how to fix it, so any help would be greatly appreciated.

alexcjohnson commented 3 years ago

Thanks @adament - we'll need to dig into the virtualized case a bit to see it this still works. In order to properly lock down the fix as well as these other cases we'll want a couple of tests - probably test_tooltip.py is the right place as well as a good starting point to create the tests.

Re: linting - npm run format should fix it for you.

tlinnet commented 2 years ago

Any update on this fix?

akullenberg-cbp commented 1 year ago

Can someone pick this up again?

kenshima4 commented 10 months ago

Hi can I have a crack at this?