search

plotly / dash-table

OBSOLETE: now part of https://github.com/plotly/dash
https://dash.plotly.com
MIT License
420 stars 74 forks source link

Old pycodestyle package cause an error while installing packages #920

Closed bitsnaps closed 2 years ago

bitsnaps commented 3 years ago

Hello,

We've been trying to recompile dash from the source, and we realized that pycodestyle used in this repo is outdated, which cause a pip (python 3.8) error during the installation:

autopep8 1.5.7 requires pycodestyle>=2.7.0, but you have pycodestyle 2.6.0 which is incompatible

Steps to reproduce: 1- Clone the repo:

git clone --depth 1 https://github.com/plotly/dash-table.git

2- Rebuild and compile:

cd dash-table && npm ci && npm run build && python setup.py sdist && mv dist/* ../packages/ && cd ..

Upgrading pycodestyle to 2.7.0 won't cause any issue, you can check this fork to reproduce the issue on Gitpod (checkout .gitpod.yml for rebuild instructions).

alexcjohnson commented 3 years ago

Thanks @bitsnaps - I don't see any errors when I follow your steps, but perhaps you're also doing pip install -r requirements.txt somewhere in there, as mentioned in the rather outdated CONTRIBUTING.md? I think we should actually delete requirements.txt and python-requirements.txt, these are unused. On CI we use dev-requirements.txt plus dash[dev,testing]

bitsnaps commented 2 years ago

@alexcjohnson That's possibly the issue, it looks like something went wrong with some pip packages, the error doesn't appear anymore, I've just compiled successfully dash-table on newly created branch along with gitpod config and updated CONTRIBUTING.md if you accept PR (you'll need to update the url in README.md).