Handle null value safely in case-insensitive filter

plotly / dash-table

OBSOLETE: now part of https://github.com/plotly/dash

https://dash.plotly.com

MIT License

420 stars 74 forks source link

Handle null value safely in case-insensitive filter #935

Open xwk opened 2 years ago

xwk commented 2 years ago

Fix the issue described in https://github.com/plotly/dash-table/issues/934

Basically if the value is null, return empty string directly instead of call .toString()

zekeshearer commented 1 year ago

I have this same issue on dash 2.8.1. @alexcjohnson or other maintainer, could you review this?

alexcjohnson commented 1 year ago

Oh thanks @zekeshearer - I had missed this PR as this repo is obsolete. I think perhaps it was created right around when we merged Dash Table into the main Dash repo.

So we can recreate it in the Dash repo. Definitely we should fix this, but I’m not sure if empty string is the right fallback, would we be better off leaving it as its non-string value so it doesn’t match an explicit empty string?

Lastly it deserves a test case.

bparzonz commented 5 months ago

Hi, this appears to still be an issue. Is it being addressed elsewhere?