search

plotly / dash

Data Apps & Dashboards for Python. No JavaScript Required.
https://plotly.com/dash
MIT License
21.35k stars 2.06k forks source link

Invalid build files in dash-renderer build directory #2660

Open T4rk1n opened 1 year ago

T4rk1n commented 1 year ago

Running the karma tests in dash-renderer (cd dash/dash-renderer && npm run test) create build files in dash/dash-renderer/build which contains the renderer distribution, these files should not be distributed along the package and fails the postbuild escheck.

Could add a clean command before the build or change the karma config to output it's build in another directory.

alexcjohnson commented 1 year ago

Moving the karma output seems cleaner, then we can gitignore that dir entirely.