Add Support for TypeScript 5.5 - Githubissues

plotly / dash

Data Apps & Dashboards for Python. No JavaScript Required.

https://plotly.com/dash

MIT License

21.49k stars 2.07k forks source link

Add Support for TypeScript 5.5 #2936

Closed samhinshaw closed 2 months ago

samhinshaw commented 3 months ago

TypeScript 5.5 adds a hard check to prevent ts.createProgam from being called on improperly parsed tsconfig files. Fortunately, the error message politely points out what function you can use to parse the tsconfig file. Hooray for code review! However, this change should be broadly backwards-compatible, as this function has been present in TypeScript since version 2.8.

Contributor Checklist

[ ] ~I have broken down my PR scope into the following TODO tasks~ N/A
[x] I have run the tests locally and they passed. (refer to testing section in contributing)
[ ] ~I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR~ N/A

optionals

[x] I have added entry in the CHANGELOG.md
[ ] ~If this PR needs a follow-up in dash docs, community thread, I have mentioned the relevant URLS as follows~ N/A

gvwilson commented 2 months ago

@T4rk1n can you please give this one last look and then merge? thank you - @gvwilson