Remove whitespace in metadata.json

plotly / dash

Data Apps & Dashboards for Python. No JavaScript Required.

https://plotly.com/dash

MIT License

21.54k stars 2.08k forks source link

Remove whitespace in metadata.json #3034

Closed alexcjohnson closed 1 month ago

alexcjohnson commented 1 month ago

Any reason we need metadata.json files to be human-readable? In some cases this is a large fraction of the total package size, eg https://github.com/snehilvj/dash-mantine-components/pull/347 (cc @AnnMarieW)

optionals

[x] I have added entry in the CHANGELOG.md

alexcjohnson commented 1 month ago

And perhaps for runtime typechecking of TS components, right?

T4rk1n commented 1 month ago

And perhaps for runtime typechecking of TS components, right?

No I think it should be generated in a .js file at generation time to have less overhead. The check is basically just window['componentlib'].component.propTypes(props, typeSpecName, componentName, ...) so the js file can set the propType for the components on the window.

AnnMarieW commented 1 month ago

So we should just delete the metadata.json file before deployment?