Create Checklist and RadioItems labels with titles

plotly / dash

Data Apps & Dashboards for Python. No JavaScript Required.

https://plotly.com/dash

MIT License

21.53k stars 2.07k forks source link

Create Checklist and RadioItems labels with titles #3068

Open giladmaya opened 2 weeks ago

giladmaya commented 2 weeks ago

This PR fixes plotly/dash#1847 and adds a title to the Checklist and RadioItems options

Contributor Checklist

[x] I have broken down my PR scope into the following TODO tasks
- Propagate title to label
- Implement integration tests
[x] I have run the tests locally and they passed. (refer to testing section in contributing)
[x] I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR

giladmaya commented 1 day ago

Looks good, just a few non blocking comments on the test refactor and missing a changelog entry.

I've addressed all your comments and pushed the changes. The tests fail as a result of an issue (unrelated to my suggested changes) with Google Chrome installation.

Can you please re-review? Thank you