search

plotly / dash

Data Apps & Dashboards for Python. No JavaScript Required.
https://plotly.com/dash
MIT License
21.2k stars 2.04k forks source link

lint tests the same way as source code #604

Open alexcjohnson opened 5 years ago

alexcjohnson commented 5 years ago

Currently we do much looser linting of our tests than we do the source code:

https://github.com/plotly/dash/blob/93246430f4129c310efe09b638d5fe6ff06e1cba/test.sh#L9-L10

454 attempted to tighten the rules in the test folder somewhat, but we somehow missed that PR and it's now obsolete. In some of our other repos we don't make a distinction between tests and source linting - can we do the same here?

byronz commented 5 years ago

by migrating already half of the tests, I think we can soon achieve this and share the same .pylintrc file as source code.