search

plotly / documentation

Issue tracker for Plotly's open-source documentation.
423 stars 546 forks source link

Example link mistake in JavaScript docs #1280

Closed simonmysun closed 5 years ago

simonmysun commented 5 years ago

Sorry that I failed to prepare the environment to debug. So I cannot submit a pull request.

Problem description

In this page there is a link to "2d Density Plots" but it is not linked in this page where it belongs.

Besides, the thumbnail image of "2D Histogram Contour" under this page is might be wrong.

simonmysun commented 5 years ago

I'm actually not sure the problem has been solved.

michaelbabyn commented 5 years ago

I just rebuilt the docs to include the change and it looks to be working now

simonmysun commented 5 years ago

Yes thanks. I have seen it working. I might need a better understanding of how Jekyll works.

Besides, I think the content is not managed well: In 2d Density Plots in plotly.js there are examples named "2D Histogram Contour Plot with Histogram Subplots" and "2D Histogram Contour Plot with Slider Control". I think it makes people confused when they are not under 2D Histogram Contour in plotly.js

Only my own opinion. Not important at all.

michaelbabyn commented 5 years ago

I think you're right that it's confusing. Maybe we should consider changing the thumbnail for 2d histogram contour to something like this to make it more clear 2d histogram contour

michaelbabyn commented 5 years ago

Regarding Jekyll, we have two main branches in this repo. source-design-merge which is where we make edits and gh-pages which is where the main content on the site comes from (more details). It wasn't until I updated the gh-pages repo that the changes were committed.

simonmysun commented 5 years ago

Right. I think you may also merge the two example page.

Thank you for the explanation. I see what happened after your commit.