plotly / documentation

Issue tracker for Plotly's open-source documentation.
423 stars 549 forks source link

Filled Lines example should use fill:'toself' instead of fill:'tozerox' #423

Open etpinard opened 8 years ago

etpinard commented 8 years ago

From @john-soklaski

This is regarding https://plot.ly/javascript/continuous-error-bars/#filled-lines If you click on "Autoscale" the confidence traces extend left, to x=0.

Adjusted version: http://codepen.io/john-soklaski/pen/YWwXGe

timelyportfolio commented 8 years ago

We also might have a couple instances of this error in the R documentation. I'll poke around to see.

john-soklaski commented 8 years ago

@etpinard Thanks for moving to the correct repo!

cldougl commented 8 years ago

Thanks for the report guys!! I updated the js and python examples (and @timelyportfolio will hit the r ones if necessary).

timelyportfolio commented 8 years ago

@cldougl, only area chart I found in R was here https://github.com/plotly/documentation/blob/source-design-merge/_posts/r/2015-07-30-filled-area-plots.Rmd, which is fine. I did notice on the cheat sheet though there is a bug in the area example.

image

I think it should read:

plot_ly(
  x = c(1,2,3),
  y = c(5,6,7),
  type = "scatter", 
  fill = "tozeroy"
)

I also searched for tozerox in R plotly https://github.com/ropensci/plotly/search?utf8=%E2%9C%93&q=tozerox and will check each of these uses of tozerox, but at first glance I am pretty sure that tozerox is correct here.

timelyportfolio commented 8 years ago

Perhaps we should add some filled line examples to the R docs.

cldougl commented 8 years ago

@timelyportfolio +1 for adding an r filled line example -- perhaps we could add https://plot.ly/r/continuous-error-bars/ (for now we just have examples in the plot.ly/ggplot2 docs ie https://plot.ly/ggplot2/stat_smooth/ and https://plot.ly/ggplot2/geom_ribbon/) Great catch - I'll fix the cheat sheet!