plotly / falcon

Free, open-source SQL client for Windows and Mac 🦅
https://plot.ly/free-sql-client-download/
MIT License
5.13k stars 277 forks source link

Reduce/Simplify the ENV variables used by Falcon #330

Open n-riesco opened 6 years ago

n-riesco commented 6 years ago

I've had a quick look at the ENV variables Falcon is using; mostly in backend/settings.js but also in:

We have some ENV variables that we don't seem to be using any longer:

And some default ENV values that break oauth for the headless app (because by default AUTH_ENABLED is true and USERS is []).

I have two proposals:

  1. remove PLOTLY_CONNECTOR_HEADLESS and PLOTLY_CONNECTOR_APP_DIRECTORY
  2. introduce PLOTLY_CONNECTOR_MODE and make USERS, AUTH_ENABLED, SSL_ENABLED, ... derived settings with defaults based on PLOTLY_CONNECTOR_MODE.

A list of possible values for PLOTLY_CONNECTOR_MODE:

@tarzzz @chriddyp What do you think of these proposals?

chriddyp commented 6 years ago

👍 sounds good to me!