Open n-riesco opened 6 years ago
I've had a quick look at the ENV variables Falcon is using; mostly in backend/settings.js but also in:
We have some ENV variables that we don't seem to be using any longer:
PLOTLY_CONNECTOR_HEADLESS
PLOTLY_CONNECTOR_APP_DIRECTORY
And some default ENV values that break oauth for the headless app (because by default AUTH_ENABLED is true and USERS is []).
AUTH_ENABLED
true
USERS
[]
I have two proposals:
PLOTLY_CONNECTOR_MODE
SSL_ENABLED
A list of possible values for PLOTLY_CONNECTOR_MODE:
desktop
web
onprem
test
mock
@tarzzz @chriddyp What do you think of these proposals?
👍 sounds good to me!
I've had a quick look at the ENV variables Falcon is using; mostly in backend/settings.js but also in:
We have some ENV variables that we don't seem to be using any longer:
PLOTLY_CONNECTOR_HEADLESS
PLOTLY_CONNECTOR_APP_DIRECTORY
And some default ENV values that break oauth for the headless app (because by default
AUTH_ENABLED
istrue
andUSERS
is[]
).I have two proposals:
PLOTLY_CONNECTOR_HEADLESS
andPLOTLY_CONNECTOR_APP_DIRECTORY
PLOTLY_CONNECTOR_MODE
and makeUSERS
,AUTH_ENABLED
,SSL_ENABLED
, ... derived settings with defaults based onPLOTLY_CONNECTOR_MODE
.A list of possible values for
PLOTLY_CONNECTOR_MODE
:desktop
(for running as an electron app)web
(for running as a web app)onprem
(for running OnPrem)test
(for testing with sample-storage)mock
(for testing with mock-storage)@tarzzz @chriddyp What do you think of these proposals?