plotly / graphing-library-docs

Plotly's graphing libraries documentation.
https://plotly.com/graphing-libraries
Other
54 stars 66 forks source link

Update title check to `page.permalink` #212

Closed LiamConnors closed 1 week ago

LiamConnors commented 1 year ago

I think all of these should be page.permalink,

nicolaskruchten commented 1 year ago

That doesn't seem right... why? This will only display the proper title if you land directly on /python/ but not any sub pages?

LiamConnors commented 1 year ago

The other pages are captured by the last condition:

{% elsif page.name %} {{page.name | capitalize}} in {{language}}{% else %} Plotly Open Source Graphing Libraries{% endif %}

Right now for any non-Python language index page it shows something like this:

image

So it seems those page titles are being created by that last condition too

But with this change we don't repeat the language and it shows like this:

image

Which is how it currently configured for Python