search

plotly / orca

Command line application for generating static images of interactive plotly charts
MIT License
294 stars 40 forks source link

Orca startup time workaround #208

Closed scjody closed 5 years ago

scjody commented 5 years ago

Workaround for https://github.com/plotly/streambed/issues/11780, plus debugging improvement.

@jkaplowitz Please review.

scjody commented 5 years ago

I think the script's fd configuration gets shared by child processes unless/until they take action to redirect theirs.

This is correct, and this is why we don't need the explicit redirection on the xvfb-run ... line anymore.

The redirections on new line 26 differ from those on former line 38 in one way: if pid 1 has different destinations for its own stdout and stderr, the old code sends the script's stdout and stderr to the corresponding pid 1 destinations, whereas the new code sends them both to pid 1's stdout.

You're right about that, and I didn't intend to make that change. I've changed it to keep stdout and stderr separate, just in case someone is relying on this behaviour. (docker logs does keep them separate.)

jkaplowitz commented 5 years ago

Great. The new revision looks good. :dancer: