test-image: fix error reporting

plotly / orca

Command line application for generating static images of interactive plotly charts

MIT License

296 stars 39 forks source link

test-image: fix error reporting #257

Closed antoinerg closed 5 years ago

antoinerg commented 5 years ago

Right now on master, running test-image on CI will yield: grep: build/test_images_diff/*.txt: No such file or directory. This regression was introduced in 697068a13a470c9b74d644f255fb2f72eeeddeed . The current PR fixes this issue.

In a nutshell, grep doesn't expand glob to match files but the shell will do it if it's not between double-quotes. Note that the script still passes a shellcheck.

etpinard commented 5 years ago

:dancer: - love it - orca getting some maintenance :pick: