search

plotly / orca

Command line application for generating static images of interactive plotly charts
MIT License
293 stars 40 forks source link

Support k8s >= 1.16 #346

Closed scjody closed 3 years ago

scjody commented 3 years ago

Switch to the apps/v1 API; all the parameters we use are still supported.

Part of https://github.com/plotly/streambed/issues/14300

1 - 3lotSp5

scjody commented 3 years ago

@BRONSOLO Please review.

@antoinerg Image tests are failing due to some image differences that you can see here. Is it OK to merge with these differences? Should I update the baselines? Something else?

antoinerg commented 3 years ago

@antoinerg Image tests are failing due to some image differences that you can see here. Is it OK to merge with these differences? Should I update the baselines? Something else?

There is only one slight difference in font rendering (the difference is in red below): fonts pdf diff

I think it's OK to merge with these differences although I'm a bit puzzled as to what caused them. Anyway, I can update the baselines for the fonts mock in a subsequent PR. @scjody